Ruff linting/formatting #543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now going to ignore all files in local settings this stuff shouldn't be being commited in my opinion
piping a hostname into exec doesn't seem like a great idea. Hopefully with a nice docker based development enviroment we won't need this kind of config any more.
this will work as a stop gap until static files can move to a cdn
|
this would presumably close #358. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/astral-sh/ruff
Ruff is an opinionated (but configurable) linter/fixer.
I'm going to make an argument that we should have a consistent and enforceable style for this project. this will hopefully save a lot of review hours going forward. (it should also help us find bugs and smelly code)
this PR includes #527 and #537 and probably should only be merged after those two.