Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelSettings.ActionMenu performance improvements #273

Conversation

luluiz
Copy link
Member

@luluiz luluiz commented Nov 21, 2024

User-Facing Changes

N/A

Description

  • Moved type to the proper file
  • Moved style to the proper file
  • Used useCallback hook to improve performance reducing unnecessary renderings.

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests
  • Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>
Copy link
Contributor

@aneuwald-ctw aneuwald-ctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ctw-joao-luis ctw-joao-luis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@luluiz luluiz merged commit 62703af into story/panel-settings-performance-improvements Nov 25, 2024
8 checks passed
@luluiz luluiz deleted the feature/action-menu-performance-improvements branch November 25, 2024 10:04
luluiz added a commit that referenced this pull request Nov 27, 2024
**User-Facing Changes**
<!-- will be used as a changelog entry -->

**Description**
Related pull requests:
| Status | Title | Link |
|--------|--------|--------|
| MERGED | PanelSettings.ActionMenu | #273 |
| MERGED | NewSidebar | #274 |
| MERGED | PanelSettings.settingsTree | #275 |
| MERGED | PanelSettings.SettingsTreeEditor | #276 | 



<!-- link relevant GitHub issues -->
<!-- add `docs` label if this PR requires documentation updates -->
<!-- add relevant metric tracking for experimental / new features -->

**Checklist**

- [x] The web version was tested and it is running ok
- [x] The desktop version was tested and it is running ok
- [x] This change is covered by unit tests
- [x] Files constants.ts, types.ts and *.style.ts have been checked and
relevant code snippets have been relocated

---------

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>
Co-authored-by: Alexandre Neuwald <alexandre.neuwald@criticaltechworks.com>
orkungursel pushed a commit to saha-robotics/lichtblick that referenced this pull request Nov 29, 2024
**User-Facing Changes**
<!-- will be used as a changelog entry -->

**Description**
Related pull requests:
| Status | Title | Link |
|--------|--------|--------|
| MERGED | PanelSettings.ActionMenu | Lichtblick-Suite#273 |
| MERGED | NewSidebar | Lichtblick-Suite#274 |
| MERGED | PanelSettings.settingsTree | Lichtblick-Suite#275 |
| MERGED | PanelSettings.SettingsTreeEditor | Lichtblick-Suite#276 | 



<!-- link relevant GitHub issues -->
<!-- add `docs` label if this PR requires documentation updates -->
<!-- add relevant metric tracking for experimental / new features -->

**Checklist**

- [x] The web version was tested and it is running ok
- [x] The desktop version was tested and it is running ok
- [x] This change is covered by unit tests
- [x] Files constants.ts, types.ts and *.style.ts have been checked and
relevant code snippets have been relocated

---------

Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>
Co-authored-by: Alexandre Neuwald <alexandre.neuwald@criticaltechworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants