-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PanelSettings.ActionMenu performance improvements #273
Merged
luluiz
merged 3 commits into
story/panel-settings-performance-improvements
from
feature/action-menu-performance-improvements
Nov 25, 2024
Merged
PanelSettings.ActionMenu performance improvements #273
luluiz
merged 3 commits into
story/panel-settings-performance-improvements
from
feature/action-menu-performance-improvements
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com>
4 tasks
aneuwald-ctw
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ctw-joao-luis
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
62703af
into
story/panel-settings-performance-improvements
8 checks passed
luluiz
added a commit
that referenced
this pull request
Nov 27, 2024
**User-Facing Changes** <!-- will be used as a changelog entry --> **Description** Related pull requests: | Status | Title | Link | |--------|--------|--------| | MERGED | PanelSettings.ActionMenu | #273 | | MERGED | NewSidebar | #274 | | MERGED | PanelSettings.settingsTree | #275 | | MERGED | PanelSettings.SettingsTreeEditor | #276 | <!-- link relevant GitHub issues --> <!-- add `docs` label if this PR requires documentation updates --> <!-- add relevant metric tracking for experimental / new features --> **Checklist** - [x] The web version was tested and it is running ok - [x] The desktop version was tested and it is running ok - [x] This change is covered by unit tests - [x] Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated --------- Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com> Co-authored-by: Alexandre Neuwald <alexandre.neuwald@criticaltechworks.com>
orkungursel
pushed a commit
to saha-robotics/lichtblick
that referenced
this pull request
Nov 29, 2024
**User-Facing Changes** <!-- will be used as a changelog entry --> **Description** Related pull requests: | Status | Title | Link | |--------|--------|--------| | MERGED | PanelSettings.ActionMenu | Lichtblick-Suite#273 | | MERGED | NewSidebar | Lichtblick-Suite#274 | | MERGED | PanelSettings.settingsTree | Lichtblick-Suite#275 | | MERGED | PanelSettings.SettingsTreeEditor | Lichtblick-Suite#276 | <!-- link relevant GitHub issues --> <!-- add `docs` label if this PR requires documentation updates --> <!-- add relevant metric tracking for experimental / new features --> **Checklist** - [x] The web version was tested and it is running ok - [x] The desktop version was tested and it is running ok - [x] This change is covered by unit tests - [x] Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated --------- Signed-off-by: Luiz Bezerra <luiz.bezerra@ctw.bmwgroup.com> Co-authored-by: Alexandre Neuwald <alexandre.neuwald@criticaltechworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
N/A
Description
Checklist