Feat/notifier-discord #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced DiscordConfig struct and added it to NotifyConfig in the API. - Implemented DiscordNotifier in internal/notifier/discord. - Registered Discord notifier in the NotifierFactory for dynamic instantiation.
…test coverage - Extract common alert decision logic () to internal/notifier/notifier.go for reuse across notifiers. - Refactor both Discord and Slack notifiers to use the shared ShouldAlert function, reducing code duplication. - Enhance Discord alert messages with advanced Markdown, emoji, and improved formatting for better readability in Discord channels. - Update and expand tests in discord_test.go to verify the new message formatting and shared alert logic.
|
Looks good to me. @tarunteja483 can you verify and merge it with the next release. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord Notifier for Endpoint Monitoring Operator
The Endpoint Monitoring Operator supports sending alerts directly to Discord channels using webhooks. This allows your team to receive real-time, well-formatted notifications for endpoint status changes.
Example Configuration
Add the following to your
EndpointMonitorresource:Example Alert
Discord alerts will look like:
