Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date input calendar getting cut off by parent #444

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

qroll
Copy link
Contributor

@qroll qroll commented Apr 11, 2024

Changes

Fix for DateInput and DateRangeInput in #443

  • Use Floating UI to handle the positioning
  • Update the animation to a fade effect
  • Expose a z-index prop (same use case as PopoverV2 - z-index conflicts)
  • [delete] branch

Changelog entry

Bug fix:

  • Fix calendar dropdown in DateInput and DateRangeInput getting cut off when it exceeds the parent container bounds

@qroll qroll requested a review from keithtxw April 11, 2024 09:59
@qroll qroll marked this pull request as draft April 11, 2024 10:28
@qroll qroll marked this pull request as ready for review April 12, 2024 09:16
@qroll qroll added the bug Something isn't working label Apr 12, 2024
@qroll qroll force-pushed the fix-calendar-cut-off branch from c3f10f6 to fd18592 Compare April 17, 2024 07:58
@keithtxw keithtxw merged commit 96c2e3b into master Apr 18, 2024
1 check passed
@keithtxw keithtxw deleted the fix-calendar-cut-off branch April 18, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants