Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom api endpoint path #136

Merged
merged 4 commits into from
Jun 13, 2024
Merged

custom api endpoint path #136

merged 4 commits into from
Jun 13, 2024

Conversation

aniketmaurya
Copy link
Collaborator

As discussed in #90, a public facing endpoint path should match the functionality to reduce confusion. Example, /classify to be used for classification and /segment to be used for segmentation.

The default endpoint remains to be /predict.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (5e6eedd) to head (ff013fa).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #136   +/-   ##
===================================
- Coverage    80%    79%   -0%     
===================================
  Files        13     13           
  Lines       864    859    -5     
===================================
- Hits        687    682    -5     
  Misses      177    177           

@aniketmaurya aniketmaurya added the enhancement New feature or request label Jun 13, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Outdated Show resolved Hide resolved
@lantiga lantiga enabled auto-merge (squash) June 13, 2024 17:30
@lantiga lantiga merged commit 7bb4c74 into main Jun 13, 2024
18 checks passed
@lantiga lantiga deleted the aniket/custom-endpoint-path branch June 13, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants