Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mp.Queue.get async for response queue #178

Merged
merged 18 commits into from
Jul 24, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jul 23, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • Rerun performance
  • Update tests

Improves throughput.

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya marked this pull request as draft July 23, 2024 18:29
@aniketmaurya aniketmaurya marked this pull request as ready for review July 23, 2024 19:06
@aniketmaurya aniketmaurya changed the title [WIP] Make mp.Queue.get async for response queue Make mp.Queue.get async for response queue Jul 23, 2024
@aniketmaurya aniketmaurya requested a review from Borda as a code owner July 23, 2024 19:38
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Let's rerun all benchmarks : )

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80%. Comparing base (36b87f4) to head (b92c14c).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #178   +/-   ##
===================================
+ Coverage    78%    80%   +2%     
===================================
  Files        13     13           
  Lines       978    991   +13     
===================================
+ Hits        766    795   +29     
+ Misses      212    196   -16     

@aniketmaurya aniketmaurya requested a review from Borda July 24, 2024 13:10
@aniketmaurya aniketmaurya enabled auto-merge (squash) July 24, 2024 13:11
@aniketmaurya aniketmaurya merged commit 07c6baf into main Jul 24, 2024
19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/fix-cpu-busy-wait branch July 24, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants