Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meaningful error message if response queues are not initialized #191

Merged
merged 5 commits into from
Aug 4, 2024

Conversation

rasbt
Copy link
Collaborator

@rasbt rasbt commented Aug 2, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Adds a meaningful error message if the response queue has not been initialized. Otherwise, you see an

AttributeError: 'LitServer' object has no attribute 'response_queue

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79%. Comparing base (75d04ca) to head (c4dfbd8).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #191   +/-   ##
===================================
- Coverage    79%    79%   -0%     
===================================
  Files        13     13           
  Lines      1036   1038    +2     
===================================
- Hits        821    819    -2     
- Misses      215    219    +4     

@aniketmaurya
Copy link
Collaborator

hi @rasbt, could you also provide a script or example where you encountered this issue? Ideally we don't want this issue to come in the first place.

@aniketmaurya aniketmaurya enabled auto-merge (squash) August 4, 2024 13:20
@aniketmaurya aniketmaurya merged commit 5b9074e into main Aug 4, 2024
16 of 17 checks passed
@aniketmaurya aniketmaurya deleted the non-init-error branch August 4, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants