Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly shutdown litserve workers #192

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (4823630) to head (63dc17d).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #192   +/-   ##
===================================
  Coverage    79%    79%           
===================================
  Files        13     13           
  Lines      1030   1040   +10     
===================================
+ Hits        811    824   +13     
+ Misses      219    216    -3     

Copy link

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test with a side-effect that raises an exception and asserts terminate is called would be useful here

@aniketmaurya
Copy link
Collaborator Author

thanks for the feedback @awaelchli! added a test to assert shutdown is called.

@aniketmaurya aniketmaurya enabled auto-merge (squash) August 6, 2024 19:06
@aniketmaurya aniketmaurya merged commit 7194fe3 into main Aug 6, 2024
19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/shutdown-properly branch August 6, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants