Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove uvicorn from argument names #199

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Aug 9, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

This PR remove uvicorn details from LitServer.run argument name.
users don't need to know the detail about uvicorn server while running LitServe.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (99b9dd7) to head (e090259).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #199   +/-   ##
===================================
  Coverage    79%    79%           
===================================
  Files        13     13           
  Lines      1032   1040    +8     
===================================
+ Hits        813    824   +11     
+ Misses      219    216    -3     

@aniketmaurya aniketmaurya merged commit d096b80 into main Aug 9, 2024
19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/rename-uvicorn-api branch August 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants