Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky batch timeout test #200

Merged
merged 4 commits into from
Aug 9, 2024
Merged

fix flaky batch timeout test #200

merged 4 commits into from
Aug 9, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Aug 9, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

Fixes flaky batch timeout test. Before hitting the /predict endpoint it first checks if the server has actually started.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (d096b80) to head (263d4d4).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #200   +/-   ##
===================================
  Coverage    79%    79%           
===================================
  Files        13     13           
  Lines      1040   1040           
===================================
  Hits        824    824           
  Misses      216    216           

@aniketmaurya
Copy link
Collaborator Author

@awaelchli could you also review it please?

@aniketmaurya aniketmaurya merged commit a3cfd56 into main Aug 9, 2024
19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/fix-flaky-test branch August 9, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants