-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test collate_request
w batch_timeout and batch_size
#238
Conversation
collate_request
w batch_timeout and batch_size
added a fix to handle |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
===================================
- Coverage 82% 82% -0%
===================================
Files 13 13
Lines 1045 1055 +10
===================================
+ Hits 854 861 +7
- Misses 191 194 +3 |
nice job @aniketmaurya. great format. let's formalize it in our template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I agree with keeping the loops separate so it's more readable
Before submitting
What does this PR do?
Fixes the
collate_request
function to handlebatch_timeout=0
, right now it is not able to return requests from the queue.Before
Test fails for the case when
batch_timeout=0
,collate_request
didn't return any item from the queue.After
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃