Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for unexpected model output in batched prediction #300

Merged
merged 24 commits into from
Sep 26, 2024

Conversation

grumpyp
Copy link
Contributor

@grumpyp grumpyp commented Sep 25, 2024

Before submitting

What does this PR do?

Fixes #294 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Yes, the Debugger is my new friend :D

Question:

Do I need to add this warning to the docs?

src/litserve/loops.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95%. Comparing base (6e9dca6) to head (4bbc92f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #300   +/-   ##
===================================
- Coverage    95%    95%   -0%     
===================================
  Files        19     19           
  Lines      1244   1237    -7     
===================================
- Hits       1182   1170   -12     
- Misses       62     67    +5     

Copy link
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR @grumpyp. Looks great! added minor comment and then we can merge.

tests/test_batch.py Outdated Show resolved Hide resolved
src/litserve/api.py Outdated Show resolved Hide resolved
@aniketmaurya aniketmaurya added the good first issue Good for newcomers label Sep 26, 2024
@aniketmaurya aniketmaurya merged commit e8ffd36 into Lightning-AI:main Sep 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected output for HF model with matching
2 participants