Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vLLM capitalization #303

Merged
merged 1 commit into from
Sep 29, 2024
Merged

fix vLLM capitalization #303

merged 1 commit into from
Sep 29, 2024

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

fix vLLM capitalization in README. The official name uses "v" in vLLM as lowercase letter.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya added the documentation Improvements or additions to documentation label Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95%. Comparing base (c2d74cc) to head (3f5139f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #303   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files        19     19           
  Lines      1257   1257           
===================================
  Hits       1195   1195           
  Misses       62     62           

@williamFalcon williamFalcon merged commit 4232377 into main Sep 29, 2024
20 checks passed
@williamFalcon williamFalcon deleted the aniketmaurya-patch-3 branch September 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants