Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jsonargparse in requirements #306

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Sep 30, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

jsonargparse was missing in requirements.txt. This PR fixes that.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya added the bug Something isn't working label Sep 30, 2024
@aniketmaurya aniketmaurya enabled auto-merge (squash) September 30, 2024 17:36
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95%. Comparing base (ac0009f) to head (5bad15f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #306   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files        21     21           
  Lines      1310   1310           
===================================
  Hits       1239   1239           
  Misses       71     71           

@aniketmaurya aniketmaurya merged commit 6b1ccc7 into main Sep 30, 2024
19 of 20 checks passed
@aniketmaurya aniketmaurya deleted the aniket/docker-add-requirements branch September 30, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants