Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host param #335

Merged
merged 35 commits into from
Oct 19, 2024
Merged

Host param #335

merged 35 commits into from
Oct 19, 2024

Conversation

grumpyp
Copy link
Contributor

@grumpyp grumpyp commented Oct 18, 2024

I need to change the Socket Binding of the underlying Uvicorn, which right now isn't possible.
I added a parameter to LitServer.run to basically use :: there.

The feature request came up by working with a Cloud provider which needs to listen to all available IPv6 interfaces.

grumpyp and others added 30 commits September 25, 2024 18:22
Co-authored-by: Aniket Maurya <theaniketmaurya@gmail.com>
Co-authored-by: Aniket Maurya <theaniketmaurya@gmail.com>
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96%. Comparing base (477d02a) to head (f2e68b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #335   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        22     22           
  Lines      1391   1394    +3     
===================================
+ Hits       1331   1334    +3     
  Misses       60     60           

Copy link
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @grumpyp! Could you add a test please?

src/litserve/server.py Show resolved Hide resolved
@aniketmaurya aniketmaurya merged commit 0284db2 into Lightning-AI:main Oct 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants