-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host param #335
Merged
Merged
Host param #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Aniket Maurya <theaniketmaurya@gmail.com>
Co-authored-by: Aniket Maurya <theaniketmaurya@gmail.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
grumpyp
requested review from
lantiga,
aniketmaurya,
ethanwharris and
Andrei-Aksionov
as code owners
October 18, 2024 19:30
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
===================================
Coverage 96% 96%
===================================
Files 22 22
Lines 1391 1394 +3
===================================
+ Hits 1331 1334 +3
Misses 60 60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @grumpyp! Could you add a test please?
aniketmaurya
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to change the Socket Binding of the underlying Uvicorn, which right now isn't possible.
I added a parameter to
LitServer.run
to basically use::
there.The feature request came up by working with a Cloud provider which needs to listen to all available IPv6 interfaces.