improve test failure msgs #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==================================
Coverage 81% 81%
==================================
Files 5 5
Lines 230 230
==================================
Hits 186 186
Misses 44 44 |
tests/test_lit_server.py
Outdated
| @@ -17,14 +16,14 @@ def test_new_pipe(lit_server): | |||
| for _ in range(pool_size): | |||
| lit_server.new_pipe() | |||
|
|
|||
| assert len(lit_server.pipe_pool) == 0 | |||
| assert len(lit_server.new_pipe()) == 2 | |||
| assert len(lit_server.pipe_pool) == 0, "pipe_pool was completely used and need to be empty" | |||
There was a problem hiding this comment.
can you describe it in non technical terms as well?
- what in the code caused this issue?
- etc...
There was a problem hiding this comment.
@williamFalcon updated
| @@ -101,7 +100,7 @@ def test_run(): | |||
| ) | |||
|
|
|||
| time.sleep(5) | |||
| assert os.path.exists("client.py") | |||
| assert os.path.exists("client.py"), f"Expected client file to be created at {os.getcwd()} after starting the server" | |||
There was a problem hiding this comment.
yes, this is a great comment
| output = subprocess.run("python client.py", shell=True, capture_output=True, text=True).stdout | ||
| assert '{"output":16.0}' in output | ||
| assert '{"output":16.0}' in output, "tests/simple_server.py didn't return expected output" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃