Skip to content

Conversation

@lianakoleva
Copy link
Contributor

First step towards addressing #1941, referencing ATen source.

@lianakoleva lianakoleva marked this pull request as ready for review April 14, 2025 23:44
@mruberry mruberry requested a review from beverlylytle April 15, 2025 15:13
@mruberry
Copy link
Collaborator

Hey @lianakoleva! Cool stuff. I made a few small comments. @beverlylytle, would you also like to take a look?

To test the implementation, we'll need to extend the "sample inputs" of interpolate, which are defined here:

def interpolate_sample_generator(op, device, dtype, requires_grad, **kwargs):

In particular, I think this part:

yield SampleInput(make(a_shape), size=size)

could be edited to look like:

yield SampleInput(make(a_shape), size=size)
yield SampleInput(make(a_shape), size=size, mode='nearest-exact')

So that both modes are tested. Please let us know if you have any questions about this, as the testing can be confusing at first!

@lianakoleva lianakoleva merged commit 08205c6 into Lightning-AI:main May 1, 2025
50 checks passed
@lianakoleva lianakoleva deleted the issue_1941 branch May 1, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants