-
Notifications
You must be signed in to change notification settings - Fork 110
Support mode 'nearest-exact' for torch.nn.functional.interpolate #1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @lianakoleva! Cool stuff. I made a few small comments. @beverlylytle, would you also like to take a look? To test the implementation, we'll need to extend the "sample inputs" of lightning-thunder/thunder/tests/opinfos.py Line 9320 in 4acf819
In particular, I think this part: lightning-thunder/thunder/tests/opinfos.py Line 9363 in 4acf819
could be edited to look like: So that both modes are tested. Please let us know if you have any questions about this, as the testing can be confusing at first! |
for more information, see https://pre-commit.ci

First step towards addressing #1941, referencing ATen source.