Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove on_train_batch_{start,end}(dataloader_idx=...) #12977

Merged
merged 2 commits into from
May 6, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 4, 2022

What does this PR do?

Part of #12521

#12769 missed these

Does your PR introduce any breaking changes? If yes, please list them.

Removes support for the deprecated argument

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @awaelchli @ninginthecloud @daniellepintz @rohitgr7

@carmocca carmocca added breaking change Includes a breaking change hooks Related to the hooks API labels May 4, 2022
@carmocca carmocca added this to the 1.7 milestone May 4, 2022
@carmocca carmocca self-assigned this May 4, 2022
@carmocca carmocca marked this pull request as ready for review May 4, 2022 17:15
@mergify mergify bot added the ready PRs ready to be merged label May 5, 2022
@carmocca carmocca enabled auto-merge (squash) May 5, 2022 19:37
@carmocca carmocca merged commit 3d74c90 into master May 6, 2022
@carmocca carmocca deleted the remove/on-train-batch-start,end branch May 6, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change hooks Related to the hooks API ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants