Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated dataloader_idx argument from on_train_batch_start/end callback hooks #12769

Merged
merged 4 commits into from
Apr 18, 2022

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Apr 15, 2022

What does this PR do?

Part of #12521. Also cleans up loose ends from call_hook refactor.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli self-assigned this Apr 15, 2022
@awaelchli awaelchli added refactor breaking change Includes a breaking change labels Apr 15, 2022
@awaelchli awaelchli added this to the 1.7 milestone Apr 15, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Apr 18, 2022
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@Borda Borda merged commit 0b22e51 into Lightning-AI:master Apr 18, 2022
@daniellepintz daniellepintz deleted the remove_dataloader_idx_arg branch April 18, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants