-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary endpoint logic, rename collaborative
to hivemind
#13392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pytorch_lightning/strategies/collaborative.py # tests/tests_pytorch/strategies/test_collaborative.py
SeanNaren
requested review from
justusschock,
kaushikb11,
williamFalcon,
Borda,
carmocca and
rohitgr7
as code owners
June 23, 2022 15:57
Borda
approved these changes
Jun 23, 2022
akihironitta
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The related doc filenames should also be renamed to hivemind
, maybe?
occurrences
$ grep -rnI collaborative docs
docs/source-pytorch/index.rst:206: Training over the internet <strategies/collaborative_training>
docs/source-pytorch/index.rst:250: Collaborative Training <strategies/collaborative_training>
docs/source-pytorch/strategies/collaborative_training.rst:1:.. _collaborative_training:
docs/source-pytorch/strategies/collaborative_training.rst:20: :button_link: collaborative_training_basic.html
docs/source-pytorch/strategies/collaborative_training.rst:28: :button_link: collaborative_training_intermediate.html
docs/source-pytorch/strategies/collaborative_training.rst:36: :button_link: collaborative_training_expert.html
docs/source-pytorch/strategies/collaborative_training_expert.rst:3:.. _collaborative_training_expert:
docs/source-pytorch/strategies/collaborative_training_expert.rst:11:Below are some ways to reduce communication when training collaboratively. As the size of your model increase, bottlenecks in communication become more apparent.
docs/source-pytorch/strategies/collaborative_training_intermediate.rst:3:.. _collaborative_training_intermediate:
docs/source-pytorch/strategies/collaborative_training_basic.rst:3:.. _collaborative_training_basic:
docs/source-pytorch/extensions/strategy.rst:78: * - collaborative
docs/source-pytorch/extensions/strategy.rst:80: - Strategy for training collaboratively on local machines or unreliable GPUs across the internet. :ref:`Learn more. <strategies/collaborative_training:Training on unreliable mixed GPUs across the internet>`
docs/source-pytorch/expertise_levels.rst:82:Learn to scale up your models and enable collaborative model development at academic or industry research labs.
docs/source-pytorch/common_usecases.rst:130: :button_link: strategies/collaborative_training
docs/source-pytorch/levels/intermediate.rst:6:Learn to scale up your models and enable collaborative model development at academic or industry research labs.
awaelchli
approved these changes
Jun 24, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jun 27, 2022
carmocca
approved these changes
Jun 27, 2022
otaj
approved these changes
Jun 28, 2022
jerome-habana
pushed a commit
to jerome-habana/lightning
that referenced
this pull request
Jul 14, 2022
…d` (Lightning-AI#13392) * Remove endpoint after collaborate app/dht CLI * Fix references, change filename * Add CHANGELOG.md * Address review Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After the introduction of the DHT CLI in hivemind, there isn't the need for the endpoint anymore. Also missed a few renames from #13388.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda