Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary endpoint logic, rename collaborative to hivemind #13392

Merged
merged 7 commits into from
Jun 28, 2022

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jun 23, 2022

What does this PR do?

After the introduction of the DHT CLI in hivemind, there isn't the need for the endpoint anymore. Also missed a few renames from #13388.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

SeanNaren added 4 commits June 23, 2022 15:31
# Conflicts:
#	src/pytorch_lightning/strategies/collaborative.py
#	tests/tests_pytorch/strategies/test_collaborative.py
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The related doc filenames should also be renamed to hivemind, maybe?

occurrences
$ grep -rnI collaborative docs
docs/source-pytorch/index.rst:206:   Training over the internet <strategies/collaborative_training>
docs/source-pytorch/index.rst:250:   Collaborative Training <strategies/collaborative_training>
docs/source-pytorch/strategies/collaborative_training.rst:1:.. _collaborative_training:
docs/source-pytorch/strategies/collaborative_training.rst:20:   :button_link: collaborative_training_basic.html
docs/source-pytorch/strategies/collaborative_training.rst:28:   :button_link: collaborative_training_intermediate.html
docs/source-pytorch/strategies/collaborative_training.rst:36:   :button_link: collaborative_training_expert.html
docs/source-pytorch/strategies/collaborative_training_expert.rst:3:.. _collaborative_training_expert:
docs/source-pytorch/strategies/collaborative_training_expert.rst:11:Below are some ways to reduce communication when training collaboratively. As the size of your model increase, bottlenecks in communication become more apparent.
docs/source-pytorch/strategies/collaborative_training_intermediate.rst:3:.. _collaborative_training_intermediate:
docs/source-pytorch/strategies/collaborative_training_basic.rst:3:.. _collaborative_training_basic:
docs/source-pytorch/extensions/strategy.rst:78:   * - collaborative
docs/source-pytorch/extensions/strategy.rst:80:     - Strategy for training collaboratively on local machines or unreliable GPUs across the internet. :ref:`Learn more. <strategies/collaborative_training:Training on unreliable mixed GPUs across the internet>`
docs/source-pytorch/expertise_levels.rst:82:Learn to scale up your models and enable collaborative model development at academic or industry research labs.
docs/source-pytorch/common_usecases.rst:130:   :button_link: strategies/collaborative_training
docs/source-pytorch/levels/intermediate.rst:6:Learn to scale up your models and enable collaborative model development at academic or industry research labs.

CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jun 23, 2022
@SeanNaren SeanNaren requested a review from edenlightning as a code owner June 24, 2022 10:10
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 27, 2022
@lexierule lexierule merged commit 54f2d44 into master Jun 28, 2022
@lexierule lexierule deleted the feat/clear_collab branch June 28, 2022 12:41
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
…d` (Lightning-AI#13392)

* Remove endpoint after collaborate app/dht CLI

* Fix references, change filename

* Add CHANGELOG.md

* Address review

Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants