Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CollaborativeStrategy to HivemindStrategy #13388

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jun 23, 2022

What does this PR do?

After discussion with the hivemind team, we've decided to follow course with the naming conventions that we've given to all other strategies. I think this primarily reduces noise, and makes it clear what the user is actually enabling.

Does your PR introduce any breaking changes? If yes, please list them.

Class name change, however since this feature has not been released in any version yet, I think it's fine to make the hard change.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @SeanNaren

Sorry, something went wrong.

@SeanNaren SeanNaren enabled auto-merge (squash) June 23, 2022 14:16
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jun 23, 2022
@SeanNaren SeanNaren merged commit 73e7a5d into master Jun 23, 2022
@SeanNaren SeanNaren deleted the fix/rename_collab_clean branch June 23, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants