-
Notifications
You must be signed in to change notification settings - Fork 64
feat: use a shared queue across workers for data processing #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use a shared queue across workers for data processing #559
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (49%) is below the target coverage (50%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
====================================
- Coverage 79% 71% -8%
====================================
Files 40 40
Lines 6098 6136 +38
====================================
- Hits 4822 4384 -438
- Misses 1276 1752 +476 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deependujha Let's keep 2 base class. One ordered and one not with a single queue
Hi @deependujha! ❌ Benchmark failed
|
closing in favour of #592 |
Before submitting
What does this PR do?
Fixes #556
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃