Update phi-3 prompt template (#1544)

litgpt/prompts.py

@@ -311,7 +311,7 @@ def apply(self, prompt: str, **kwargs: str) -> str:
 
 class Phi3(PromptStyle):
     def apply(self, prompt: str, **kwargs: str) -> str:
-        return f'<s><|user|>\n{prompt}<|end|>\n<|assistant|>\n'
+        return f'<|system|>\nYou are a helpful assistant.<|end|>\n<|user|>\n{prompt}<|end|>\n<|assistant|>\n'
 
 
 

tests/test_tokenizer.py

@@ -75,9 +75,6 @@ def test_tokenizer_against_hf(config):
         # TODO: there's a encoding difference with this model. why? note that the decoding is equal
         # "Hello": 10994, "▁Hello": 15043
         assert [15043 if t == 10994 else t for t in actual.tolist()] == expected
-    elif config.name.startswith("Phi-3"):
-        # Phi-3 tokenizer adds `bos` twice
-        assert [ours.bos_id] + actual.tolist() == expected
     else:
         assert actual.tolist() == expected
     assert ours.decode(actual) == theirs.decode(expected, skip_special_tokens=True)