Fix capturing hparams for loggers that don't support serializing non-primitives #1281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version of LitGPT, I added this code to sanitize the hparams for logging:
litgpt/pretrain/tinyllama.py
Line 65 in 8a101b6
But this code was removed in the new version, causing errors like:
(e.g. with wandb)
I plan to improve this in Lightning's
.log_hyperparameters()
implementation, after which we can remove the function I added here again.