Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download_model_weights.md #1300

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

eltociear
Copy link
Contributor

specifiy -> specify

@thuan00
Copy link

thuan00 commented Apr 16, 2024

hi Ikko,
im intrigued by your constant effort on fixing typos and providing japanese translations
i really like to understand your motivation or process of doing so too

your work is nice
however, personally i dont think there is much value in fixing trivial, harmless, infrequent typos
the same goes for translating (as people can use machine translation or just learn the international language gradually)

i think the world has many many more critical issues and we better prioritize more important work

let me know your views

@williamFalcon
Copy link
Contributor

williamFalcon commented Apr 16, 2024

hi Ikko, im intrigued by your constant effort on fixing typos and providing japanese translations i really like to understand your motivation or process of doing so too

your work is nice however, personally i dont think there is much value in fixing trivial, harmless, infrequent typos the same goes for translating (as people can use machine translation or just learn the international language gradually)

i think the world has many many more critical issues and we better prioritize more important work

let me know your views

@thuan00 i disagree here. Documentation and typos are super important. I appreciate the work @eltociear is doing here. In general, I'd like to think that the Lightning community is open, inclusive and appreciates contributions no matter how small.

@Andrei-Aksionov
Copy link
Collaborator

Hey @thuan00
I believe that every contribution counts, even if it's just a typo fix.
That is what makes an open source community great: everyone tries to help make the repo better in his own way.

@thuan00
Copy link

thuan00 commented Apr 16, 2024

great views
i dont mean to under-appreciate or even see the work as valueless or to close the PR
contributions are welcome

what i mean is to understand and maybe suggest more important or valuable work
for example, if not humanity issues like climate change or poverty, if not the AI community's challenges and tasks, if, say, in the scope of this repo's typo issues, i can see quite a few more typos in many other files
maybe we can use some automated tool to correct typos holistically and effectively
maybe a commit with more typos being fixed

i am a bit worried for Ikko if his work is manual, time consuming
or triggered by things like OCD or driven by some other unhealthy motivation

sorry for taking things personally here
i can discuss this in a different channel

@lantiga
Copy link
Contributor

lantiga commented Apr 16, 2024

@eltociear found the typo and sent a PR to fix it, we welcome this without reservations.

Every other consideration about the PR is out of scope, and any personal consideration about contributors themselves is definitely misplaced.

@rasbt
Copy link
Collaborator

rasbt commented Apr 16, 2024

Thanks a lot for the PR @eltociear! Contributions like this help keeping projects neat & professional!

@rasbt rasbt merged commit 2bda868 into Lightning-AI:main Apr 16, 2024
9 checks passed
@eltociear
Copy link
Contributor Author

eltociear commented Apr 17, 2024

Hi @thuan00 !
I too understand that there are more important fixes than a small typo like this one.
However, typo fixes can be modest but sometimes significant!
(A typo in a comment can be the source of a bug due to a misunderstanding, a small mistake in a prompt can twist the result generated by the AI, etc.)

As for translation, there is machine translation, and I am sure AI will eventually take over,
However, at present, it is still difficult to understand the nuances of the translation.

I also think that it would be easier to get used to the system if there were documents in the native language, so I am adding translations in order to promote the use of the system.

I may be suffering from some kind of disease, but I enjoy reading documents and looking for corrections.

@eltociear
Copy link
Contributor Author

@williamFalcon @Andrei-Aksionov @lantiga @rasbt
Thank you for accepting me!
Wish our relationship would last forever.

@thuan00
Copy link

thuan00 commented Apr 17, 2024

alright @eltociear
nice to learn about your views
wish you well
hope to help in case you have any problem

btw, maybe a tool like this can be helpful for your interest in typos
https://crates.io/crates/typos
i saw it on a random PR
ggerganov/llama.cpp#4354

@evdcush
Copy link

evdcush commented Apr 29, 2024

Thanks a lot for the PR @eltociear! Contributions like this help keeping projects neat & professional!

@williamFalcon @Andrei-Aksionov @lantiga @rasbt

I'm so glad to see how personally involved and encouraging Lightning folks are in review and contributions 🙏🏻

That being said, not all contributors are necessarily looking to support or benefit your software.

This user, eltociear, makes trivial diffs to documentation in any trendy or recently public repo related to AI on github to feature in the contributors.

For example:

  • "Github" --> "GitHub"
  • "Huggingface" --> "Hugging Face"
  • "an" <--> "a"

Ref:

This kind of behavior hurts FLOSS :finnadie:

@TataKKKL
Copy link

TataKKKL commented May 1, 2024

@eltociear have you considered building an AI agent to automate this process?

@eltociear
Copy link
Contributor Author

@Tata0703 I am not considering it at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants