Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wrap LoRA layers with FSDP #1538

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Do not wrap LoRA layers with FSDP #1538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa965cc
Do not wrap LoRA layers with FSDP
janEbert Jun 28, 2024
0bd44ac
Merge branch 'main' into fsdp-lora
rasbt Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion litgpt/finetune/lora.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def setup(
" --quantize flag."
)
strategy = FSDPStrategy(
auto_wrap_policy={Block},
auto_wrap_policy={torch.nn.Linear},
activation_checkpointing_policy={Block},
state_dict_type="full",
limit_all_gathers=True,
Expand Down
Loading