Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lightning version to 2.4.0 pre #1640

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Update Lightning version to 2.4.0 pre #1640

merged 1 commit into from
Jul 29, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 29, 2024

Includes the fix: Lightning-AI/pytorch-lightning#20121 @rasbt
There will be a 2.4 release soon.

Closes #1604 (?)

@awaelchli awaelchli requested a review from lantiga as a code owner July 29, 2024 18:58
@awaelchli awaelchli requested a review from rasbt July 29, 2024 19:06
@rasbt
Copy link
Collaborator

rasbt commented Jul 29, 2024

Thanks! There should be a test for this now (something I added via the previous PR) but I just additionally manually checked and it works great!

@rasbt rasbt merged commit 11b34d7 into main Jul 29, 2024
8 checks passed
@rasbt rasbt deleted the feature/bump-lightning branch July 29, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QLoRA / bnb.nf4 quantization causes issues in recent PyTorch Lightning/Fabric versions
2 participants