Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Support for Dolly, Nous-Hermes, Redpajama-Incite, Vicuna and H2O Danube Models. #1821

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Nov 3, 2024

Addresses Issue #1401. I've removed support for the majority of the models, and the Danube2 model mentioned in the issue. I chose not to deprecate the Platypus model as it has some additional dependencies that need to be managed carefully. Are there further files that need to be modified?

Please let me know, and I will make the necessary changes as required.

Longchat, Nous Research, Danube models.
@ParagEkbote
Copy link
Contributor Author

Could you please review the changes?

cc: @rasbt

@rasbt
Copy link
Collaborator

rasbt commented Nov 4, 2024

Thanks for the PR! This looks good to me. Let me CC @lantiga for a second look

@ParagEkbote
Copy link
Contributor Author

Could you please review the changes?

cc: @lantiga

@ParagEkbote
Copy link
Contributor Author

Could you please review the changes?

cc: @lantiga

Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your patience @ParagEkbote

@lantiga lantiga merged commit 33eab00 into Lightning-AI:main Nov 11, 2024
9 checks passed
@ParagEkbote ParagEkbote deleted the remove-old-models branch November 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants