Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Deprecated compute_on_step from audio #1007

Merged
merged 3 commits into from
May 5, 2022

Conversation

tanmoyio
Copy link
Contributor

@tanmoyio tanmoyio commented May 4, 2022

What does this PR do?

Part of #956 - audio

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #1007 (a369005) into master (6144eb3) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1007   +/-   ##
======================================
- Coverage      95%     95%   -0%     
======================================
  Files         179     179           
  Lines        7652    7652           
======================================
- Hits         7263    7250   -13     
- Misses        389     402   +13     

@Borda Borda mentioned this pull request May 5, 2022
9 tasks
@mergify mergify bot added the ready label May 5, 2022
@Borda Borda enabled auto-merge (squash) May 5, 2022 09:45
@Borda Borda merged commit 1789b17 into Lightning-AI:master May 5, 2022
@Borda Borda added this to the v0.8 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants