Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: wer #714

Merged
merged 5 commits into from
Jan 6, 2022
Merged

refactor: wer #714

merged 5 commits into from
Jan 6, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 5, 2022 •
edited
Loading

What does this PR do?

let's be more descriptive
part of #729

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added refactoring refactoring and code health API / design labels Jan 5, 2022
@Borda Borda added this to the v0.7 milestone Jan 5, 2022
@Borda Borda self-assigned this Jan 5, 2022
@Borda Borda changed the title word_error_rate refactor: web Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022 •
edited
Loading

Codecov Report

Merging #714 (aaf3b15) into master (5c18b6b) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #714   +/-   ##
=====================================
  Coverage      73%    73%           
=====================================
  Files         166    166           
  Lines        6439   6448    +9     
=====================================
+ Hits         4704   4713    +9     
  Misses       1735   1735

justusschock
justusschock approved these changes Jan 5, 2022
View reviewed changes
torchmetrics/functional/text/wer.py Outdated Show resolved Hide resolved
torchmetrics/functional/text/__init__.py Outdated Show resolved Hide resolved
torchmetrics/functional/__init__.py Outdated Show resolved Hide resolved
torchmetrics/functional/__init__.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Jan 5, 2022
@justusschock justusschock mentioned this pull request Jan 5, 2022
Merged
4 tasks
@Borda Borda changed the title refactor: web refactor: wer Jan 5, 2022
Borda
Borda commented Jan 5, 2022
View reviewed changes
torchmetrics/text/wer.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the ready label Jan 5, 2022
@Borda @justusschock
typo
329f324 
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
stancld
stancld approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot removed the has conflicts label Jan 6, 2022
@SkafteNicki SkafteNicki enabled auto-merge (squash) January 6, 2022 09:37
@Borda Borda disabled auto-merge January 6, 2022 09:39
@Borda Borda merged commit aa05557 into master Jan 6, 2022
@Borda Borda deleted the refactor/web branch January 6, 2022 09:40
@Borda Borda mentioned this pull request Jan 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@stancld stancld stancld approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton

Assignees

@Borda Borda

Labels
API / design ready refactoring refactoring and code health
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@Borda @justusschock @SkafteNicki @stancld