Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ter #713

Merged
merged 6 commits into from
Jan 6, 2022
Merged

refactor: ter #713

merged 6 commits into from
Jan 6, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 5, 2022

What does this PR do?

let's be more descriptive and no need for deprecation here as this has not been released yet
part of #729

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #713 (81355ae) into master (89f603b) will not change coverage.
The diff coverage is 100%.

❗ Current head 81355ae differs from pull request most recent head 07a6a8c. Consider uploading reports for the commit 07a6a8c to get more accurate results

@@          Coverage Diff          @@
##           master   #713   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         166    166           
  Lines        6424   6424           
=====================================
  Hits         6117   6117           
  Misses        307    307           

@Borda Borda changed the title refactor: translation edit rate refactor: ter Jan 5, 2022
@Borda Borda self-assigned this Jan 5, 2022
@Borda Borda added this to the v0.7 milestone Jan 5, 2022
@mergify mergify bot added the ready label Jan 5, 2022
@mergify mergify bot removed the ready label Jan 5, 2022
@mergify mergify bot added the ready label Jan 5, 2022
@Borda Borda merged commit 5c18b6b into master Jan 6, 2022
@Borda Borda deleted the refactor/ter branch January 6, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants