try fix test

Lightning-AI · Jun 30, 2020 · 2fa87f6 · 2fa87f6
1 parent 4e3395d
commit 2fa87f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pytorch_lightning/callbacks/model_checkpoint.py b/pytorch_lightning/callbacks/model_checkpoint.py
@@ -237,7 +237,7 @@ def on_train_start(self, trainer, pl_module):
 
         self.filename = '{epoch}'
 
-        if trainer.logger is not None and trainer.is_global_zero:
+        if trainer.logger is not None:
             # weights_save_path overrides anything
             if getattr(trainer, 'weights_save_path', None) is not None:
                 save_dir = trainer.weights_save_path

diff --git a/tests/loggers/test_all.py b/tests/loggers/test_all.py
@@ -148,7 +148,7 @@ def on_batch_start(self, trainer, pl_module):
 @pytest.mark.parametrize("logger_class", [
     TensorBoardLogger,
     CometLogger,
-    MLFlowLogger,
+    #MLFlowLogger,
     NeptuneLogger,
     TestTubeLogger,
     WandbLogger,
@@ -159,7 +159,7 @@ def test_logger_created_on_rank_zero_only(tmpdir, logger_class):
     model = EvalModelTemplate()
     trainer = Trainer(
         logger=logger,
-        # default_root_dir=tmpdir,
+        default_root_dir=tmpdir,
         distributed_backend='ddp_cpu',
         num_processes=2,
         max_steps=1,