Disable pl optimizer temporarily to fix AMP issues (#5163)

* Disable pl optimizer temporarily to fix AMP issues * Add todo and enable pl optimizer in the test
Lightning-AI · Jan 4, 2021 · 34c585b · 34c585b
1 parent d757f8b
commit 34c585b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pytorch_lightning/trainer/trainer.py b/pytorch_lightning/trainer/trainer.py
@@ -133,7 +133,7 @@ def __init__(
  distributed_backend: Optional[str] = None,
  automatic_optimization: Optional[bool] = None,
  move_metrics_to_cpu: bool = False,
- enable_pl_optimizer: bool = True,
+ enable_pl_optimizer: bool = False,
  multiple_trainloader_mode: str = 'max_size_cycle',
  ):
  r"""

diff --git a/tests/callbacks/test_callbacks.py b/tests/callbacks/test_callbacks.py
@@ -33,6 +33,8 @@ def test_trainer_callback_system(torch_save):
  limit_train_batches=3,
  limit_test_batches=2,
  progress_bar_refresh_rate=0,
+ # todo: enabled since internally we wrap the model for optimizer step, this should be fixed
+ enable_pl_optimizer=True
  )
 
  # no call yet