Remove numpy from base requirements (#20090)

Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
Lightning-AI · Jul 18, 2024 · 5ecbbaa · 5ecbbaa
1 parent d3f9c83
commit 5ecbbaa
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/_legacy-checkpoints.yml b/.github/workflows/_legacy-checkpoints.yml
@@ -114,8 +114,8 @@ jobs:
       - name: Upload checkpoints to S3
         working-directory: ${{ env.LEGACY_FOLDER }}
         env:
-          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_PUB_ACCESS_KEY }}
-          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_PUB_SECRET_KEY }}
+          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY }}
+          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_KEY }}
           AWS_DEFAULT_REGION: ${{ secrets.AWS_REGION }}
         run: |
           aws s3 sync $AWS_RUN checkpoints/ s3://pl-public-data/legacy/checkpoints/

diff --git a/requirements/fabric/base.txt b/requirements/fabric/base.txt
@@ -1,7 +1,6 @@
 # NOTE: the upper bound for the package version is only set for CI stability, and it is dropped while installing this package
 #  in case you want to preserve/enforce restrictions on the latest compatible version, add "strict" as an in-line comment
 
-numpy >=1.21.0, <1.27.0
 torch >=2.1.0, <2.5.0
 fsspec[http] >=2022.5.0, <2024.4.0
 packaging >=20.0, <=23.1

diff --git a/requirements/fabric/test.txt b/requirements/fabric/test.txt
@@ -1,4 +1,5 @@
 coverage ==7.3.1
+numpy >=1.17.2, <1.27.0
 pytest ==7.4.0
 pytest-cov ==4.1.0
 pytest-timeout ==2.1.0

diff --git a/requirements/pytorch/base.txt b/requirements/pytorch/base.txt
@@ -1,7 +1,6 @@
 # NOTE: the upper bound for the package version is only set for CI stability, and it is dropped while installing this package
 #  in case you want to preserve/enforce restrictions on the latest compatible version, add "strict" as an in-line comment
 
-numpy >=1.21.0, <1.27.0
 torch >=2.1.0, <2.5.0
 tqdm >=4.57.0, <4.67.0
 PyYAML >=5.4, <6.1.0

diff --git a/requirements/pytorch/test.txt b/requirements/pytorch/test.txt
@@ -8,6 +8,7 @@ pytest-random-order ==1.1.0
 # needed in tests
 cloudpickle >=1.3, <2.3.0
 scikit-learn >0.22.1, <1.4.0
+numpy >=1.17.2, <1.27.0
 onnx >=1.12.0, <1.17.0
 onnxruntime >=1.12.0, <1.19.0
 psutil <5.9.6 # for `DeviceStatsMonitor`

diff --git a/src/lightning/fabric/CHANGELOG.md b/src/lightning/fabric/CHANGELOG.md
@@ -17,7 +17,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 - Changed the implementation of how seeds are chosen for dataloader workers when using `seed_everything(..., workers=True)` ([#20055](https://github.com/Lightning-AI/pytorch-lightning/pull/20055))
 
--
+- NumPy is no longer a required dependency ([#20090](https://github.com/Lightning-AI/pytorch-lightning/issues/20090))
 
 ### Deprecated
 

diff --git a/src/lightning/pytorch/CHANGELOG.md b/src/lightning/pytorch/CHANGELOG.md
@@ -21,6 +21,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 - Changed the implementation of how seeds are chosen for dataloader workers when using `seed_everything(..., workers=True)` ([#20055](https://github.com/Lightning-AI/pytorch-lightning/pull/20055))
 
+- NumPy is no longer a required dependency ([#20090](https://github.com/Lightning-AI/pytorch-lightning/issues/20090))
 
 ### Deprecated
-Original file line number
+Diff line change
@@ Expand Up @@
     - Changed the implementation of how seeds are chosen for dataloader workers when using `seed_everything(..., workers=True)` ([#20055](https://github.com/Lightning-AI/pytorch-lightning/pull/20055))
-    -
+    - NumPy is no longer a required dependency ([#20090](https://github.com/Lightning-AI/pytorch-lightning/issues/20090))
     ### Deprecated
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
Expand Up		@@ -21,6 +21,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

		- Changed the implementation of how seeds are chosen for dataloader workers when using `seed_everything(..., workers=True)` ([#20055](https://github.com/Lightning-AI/pytorch-lightning/pull/20055))

		- NumPy is no longer a required dependency ([#20090](https://github.com/Lightning-AI/pytorch-lightning/issues/20090))

		### Deprecated

Expand Down