Skip to content

Commit

Permalink
Add ddp_find_unused_parameters_true alias in Fabric's DDPStrategy (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
01AbhiSingh authored Aug 7, 2024
1 parent 2129fdf commit be0ae06
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
7 changes: 7 additions & 0 deletions src/lightning/fabric/strategies/ddp.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,13 @@ def register_strategies(cls, strategy_registry: _StrategyRegistry) -> None:
description=f"DDP strategy with `start_method={start_method!r}`",
start_method=start_method,
)
strategy_registry.register(
"ddp_find_unused_parameters_true",
cls,
description="Alias for `find_unused_parameters_true` and `start_method='popen'`",
find_unused_parameters=True,
start_method="popen",
)

def _setup_distributed(self) -> None:
self._set_world_ranks()
Expand Down
1 change: 1 addition & 0 deletions tests/tests_fabric/strategies/test_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def __init__(self, param1, param2):
def test_available_strategies_in_registry():
expected = {
"ddp",
"ddp_find_unused_parameters_true",
"deepspeed",
"deepspeed_stage_1",
"deepspeed_stage_1_offload",
Expand Down
3 changes: 2 additions & 1 deletion tests/tests_fabric/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,9 @@ def test_run_env_vars_strategy(_, strategy, monkeypatch, fake_script):
def test_run_get_supported_strategies():
"""Test to ensure that when new strategies get added, we must consider updating the list of supported ones in the
CLI."""
assert len(_get_supported_strategies()) == 7
assert len(_get_supported_strategies()) == 8
assert "fsdp" in _get_supported_strategies()
assert "ddp_find_unused_parameters_true" in _get_supported_strategies()


@pytest.mark.parametrize("strategy", ["ddp_spawn", "ddp_fork", "ddp_notebook", "deepspeed_stage_3_offload"])
Expand Down

0 comments on commit be0ae06

Please sign in to comment.