Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy from base requirements #20090

Merged

Conversation

01AbhiSingh
Copy link
Contributor

@01AbhiSingh 01AbhiSingh commented Jul 15, 2024

What does this PR do?

Fixes #16649

following changes were made :

# NOTE: the upper bound for the package version is only set for CI stability, and it is dropped while installing this package
#  in case you want to preserve/enforce restrictions on the latest compatible version, add "strict" as an in-line comment

torch >=1.13.0, <2.3.0
fsspec[http] >=2022.5.0, <2023.11.0
packaging >=20.0, <=23.1
typing-extensions >=4.4.0, <4.10.0
lightning-utilities >=0.8.0, <0.12.0

tagging @awaelchli for better visibility.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20090.org.readthedocs.build/en/20090/

@github-actions github-actions bot added fabric lightning.fabric.Fabric dependencies Pull requests that update a dependency file labels Jul 15, 2024
@awaelchli
Copy link
Contributor

Hey @01AbhiSingh Looks good. You also need to remove it here:

numpy >=1.21.0, <1.27.0

Since we still need numpy for testing, and it's no longer in the base requirements, you'll have to add it to the test files:
https://github.com/Lightning-AI/pytorch-lightning/blob/master/requirements/pytorch/test.txt
https://github.com/Lightning-AI/pytorch-lightning/blob/master/requirements/fabric/test.txt

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 15, 2024
@01AbhiSingh
Copy link
Contributor Author

@awaelchli Made the suggested changes, please check.

@awaelchli awaelchli added this to the 2.4 milestone Jul 15, 2024
@awaelchli awaelchli added the community This PR is from the community label Jul 15, 2024
@mergify mergify bot removed the has conflicts label Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91%. Comparing base (74470a6) to head (0766ef2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20090   +/-   ##
=======================================
  Coverage      91%      91%           
=======================================
  Files         266      266           
  Lines       22986    22986           
=======================================
+ Hits        20817    20818    +1     
+ Misses       2169     2168    -1     

@github-actions github-actions bot added the ci Continuous Integration label Jul 17, 2024
@awaelchli awaelchli merged commit 5ecbbaa into Lightning-AI:master Jul 18, 2024
114 of 115 checks passed
weiji14 added a commit to regro-cf-autotick-bot/lightning-feedstock that referenced this pull request Aug 7, 2024
Python 3.8 support was removed in Lightning-AI/pytorch-lightning#20071, and runtime dependency on NumPy was removed in Lightning-AI/pytorch-lightning#20090
weiji14 added a commit to conda-forge/lightning-feedstock that referenced this pull request Aug 7, 2024
* updated v2.4.0

* MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.37.2, and conda-forge-pinning 2024.08.07.04.40.03

* Bump minimum version of Python to 3.9 and drop numpy

Python 3.8 support was removed in Lightning-AI/pytorch-lightning#20071, and runtime dependency on NumPy was removed in Lightning-AI/pytorch-lightning#20090

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration community This PR is from the community dependencies Pull requests that update a dependency file fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop the numpy requirement
3 participants