-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove numpy from base requirements #20090
Remove numpy from base requirements #20090
Conversation
Hey @01AbhiSingh Looks good. You also need to remove it here:
Since we still need numpy for testing, and it's no longer in the base requirements, you'll have to add it to the test files: |
@awaelchli Made the suggested changes, please check. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20090 +/- ##
=======================================
Coverage 91% 91%
=======================================
Files 266 266
Lines 22986 22986
=======================================
+ Hits 20817 20818 +1
+ Misses 2169 2168 -1 |
Python 3.8 support was removed in Lightning-AI/pytorch-lightning#20071, and runtime dependency on NumPy was removed in Lightning-AI/pytorch-lightning#20090
* updated v2.4.0 * MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.37.2, and conda-forge-pinning 2024.08.07.04.40.03 * Bump minimum version of Python to 3.9 and drop numpy Python 3.8 support was removed in Lightning-AI/pytorch-lightning#20071, and runtime dependency on NumPy was removed in Lightning-AI/pytorch-lightning#20090 --------- Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
What does this PR do?
Fixes #16649
following changes were made :
tagging @awaelchli for better visibility.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20090.org.readthedocs.build/en/20090/