Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reset_on_restart within the loop #9562

Closed
tchaton opened this issue Sep 16, 2021 · 0 comments · Fixed by #9561
Closed

Move reset_on_restart within the loop #9562

tchaton opened this issue Sep 16, 2021 · 0 comments · Fixed by #9561
Assignees
Labels

Comments

@tchaton
Copy link
Contributor

tchaton commented Sep 16, 2021

Proposed refactoring or deprecation

Motivation

Currently, the loop reset_on_restart the progress while reloading the states. This means setting ready, started value to the processed / completed one.

This hidden behaviour can be mis-leading and should be exposed within the reset function of the loop.

Pitch

Additional context


If you enjoy Lightning, check out our other projects! ⚡

  • Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

  • Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, finetuning and solving problems with deep learning

  • Bolts: Pretrained SOTA Deep Learning models, callbacks and more for research and production with PyTorch Lightning and PyTorch

  • Lightning Transformers: Flexible interface for high performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant