[Refactor] Move reset_on_restart within the loop reset #9561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren and
williamFalcon
as code owners
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
tchaton
force-pushed
the
move_restart_with_loops
branch
from
c3f3f7e to
e9a46d0
Compare
tchaton
changed the title
carmocca
reviewed
Sep 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #9561 +/- ##
======================================
Coverage 93% 93%
======================================
Files 180 181 +1
Lines 15092 15170 +78
======================================
+ Hits 14020 14094 +74
- Misses 1072 1076 +4 |
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
…ightning/pytorch-lightning into move_restart_with_loops
awaelchli
reviewed
Sep 17, 2021
tchaton
changed the title
Hey @awaelchli, I apologise. I started and was caught into something else. I have added a description and the PR is ready. Best, |
12 tasks
awaelchli
reviewed
Sep 17, 2021
awaelchli
approved these changes
Sep 17, 2021
carmocca
approved these changes
Sep 17, 2021
justusschock
approved these changes
Sep 17, 2021
…ightning/pytorch-lightning into move_restart_with_loops
SeanNaren
pushed a commit
that referenced
this pull request
Sep 22, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, the loop reset_on_restart the progress while reloading the states. This means setting ready, started value to the processed / completed one.
This hidden behaviour can be mis-leading and should be exposed within the reset function of the loop.
Fixes #9562
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃