-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update strategy flag in docs #10000
Merged
Merged
Update strategy flag in docs #10000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
carmocca
reviewed
Oct 19, 2021
kaushikb11
changed the title
Update strategy flag in docs
(1/n) Update strategy flag in docs
Oct 19, 2021
kaushikb11
requested review from
ananthsub,
awaelchli,
Borda,
edenlightning,
justusschock,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 19, 2021 19:24
kaushikb11
changed the title
(1/n) Update strategy flag in docs
Update strategy flag in docs
Oct 19, 2021
carmocca
approved these changes
Oct 19, 2021
carmocca
reviewed
Oct 19, 2021
carmocca
reviewed
Oct 19, 2021
Codecov Report
@@ Coverage Diff @@
## master #10000 +/- ##
=======================================
- Coverage 93% 93% -0%
=======================================
Files 180 180
Lines 15892 15892
=======================================
- Hits 14722 14720 -2
- Misses 1170 1172 +2 |
awaelchli
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find and replace 📎 ✏️
Borda
approved these changes
Oct 19, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
12 tasks
rohitgr7
reviewed
Oct 20, 2021
rohitgr7
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update
strategy
flag in the docs. It will replaceaccelerator
andplugins
flags for training strategies.Related Issues: #9053, #9932
The follow-up PR would be updating the Trainer flag documentation (accelerator, strategy) and required changes for
ddp_cpu
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃