-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup logic in training type plugins (deepspeed) [2 / n] #10009
Merged
awaelchli
merged 10 commits into
master
from
lightning-lite/refactors/deepspeed-setup-2
Oct 19, 2021
Merged
Update setup logic in training type plugins (deepspeed) [2 / n] #10009
awaelchli
merged 10 commits into
master
from
lightning-lite/refactors/deepspeed-setup-2
Oct 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
reviewed
Oct 19, 2021
tchaton
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Co-authored-by: Sean Naren <sean@grid.ai>
justusschock
approved these changes
Oct 19, 2021
awaelchli
requested review from
Borda,
carmocca,
kaushikb11,
rohitgr7 and
williamFalcon
as code owners
October 19, 2021 15:53
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #10009 +/- ##
========================================
+ Coverage 89% 93% +4%
========================================
Files 180 180
Lines 15854 15868 +14
========================================
+ Hits 14066 14685 +619
+ Misses 1788 1183 -605 |
carmocca
approved these changes
Oct 19, 2021
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #9987
Follow up to #9994
Implements
_setup_models_and_optimizers
for the Deepspeed pluginDoes your PR introduce any breaking changes? If yes, please list them.
No.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃