Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise MisconfigurationException if trainer.eval is missing required methods #10016

Merged
merged 18 commits into from
Oct 26, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 19, 2021

What does this PR do?

Follow up: #9976
More info: #9976 (comment)
In short trainer.predict raises an exception but trainer.validate/test doesn't in case eval_step/eval_dataloader is missing.
Also did a little cleanup and a small bugfix which came up after the changes.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #10016 (db292c3) into master (0e20119) will decrease coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10016   +/-   ##
=======================================
- Coverage      93%      93%   -0%     
=======================================
  Files         182      182           
  Lines       16147    16149    +2     
=======================================
+ Hits        14937    14938    +1     
- Misses       1210     1211    +1     

@rohitgr7 rohitgr7 added the design Includes a design discussion label Oct 19, 2021
@rohitgr7 rohitgr7 added this to the v1.5 milestone Oct 19, 2021
CHANGELOG.md Show resolved Hide resolved
@awaelchli awaelchli added the feature Is an improvement or enhancement label Oct 19, 2021
@rohitgr7 rohitgr7 self-assigned this Oct 20, 2021
@mergify mergify bot removed the has conflicts label Oct 25, 2021
@rohitgr7 rohitgr7 disabled auto-merge October 25, 2021 16:02
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 25, 2021 16:03
@mergify mergify bot removed the has conflicts label Oct 25, 2021
@rohitgr7 rohitgr7 merged commit 34d5980 into master Oct 26, 2021
@rohitgr7 rohitgr7 deleted the ref/eval_ver branch October 26, 2021 06:12
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants