Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning Lite docs #10176

Merged
merged 31 commits into from
Oct 30, 2021
Merged

Lightning Lite docs #10176

merged 31 commits into from
Oct 30, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 27, 2021

What does this PR do?

Part of #9987
This should be merged after #10175

This is the V1 for the new Lightning Lite package. Planned to be released as part of 1.5.

Demo

Lightning Lite Demo

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli added docs Documentation related fabric lightning.fabric.Fabric labels Oct 27, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 27, 2021
@awaelchli awaelchli mentioned this pull request Oct 27, 2021
23 tasks
@awaelchli awaelchli marked this pull request as ready for review October 27, 2021 15:58
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool 🔥

docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
Co-authored-by: Aki Nitta <nitta@akihironitta.com>
@awaelchli awaelchli mentioned this pull request Oct 28, 2021
11 tasks
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Show resolved Hide resolved
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so cool 🎉 🚀

docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
@tchaton tchaton requested a review from SkafteNicki October 30, 2021 08:11
docs/source/starter/lightning_lite.rst Outdated Show resolved Hide resolved
@tchaton tchaton enabled auto-merge (squash) October 30, 2021 09:02
@tchaton tchaton disabled auto-merge October 30, 2021 09:02
@tchaton tchaton enabled auto-merge (squash) October 30, 2021 09:18
@tchaton tchaton disabled auto-merge October 30, 2021 09:28
@tchaton tchaton enabled auto-merge (squash) October 30, 2021 09:31
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tchaton tchaton merged commit d33429c into master Oct 30, 2021
@tchaton tchaton deleted the lightning-lite/docs branch October 30, 2021 10:25
@carmocca carmocca mentioned this pull request Nov 4, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants