Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Nov 3, 2021

What does this PR do?

Closes #10090

Tries to update the bfloat16 docs a bit with information following the motivations from the related issue.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the docs Documentation related label Nov 3, 2021
@SeanNaren SeanNaren added this to the v1.6 milestone Nov 3, 2021
@SeanNaren SeanNaren self-assigned this Nov 3, 2021
@SeanNaren SeanNaren marked this pull request as ready for review November 3, 2021 22:04
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@mergify mergify bot added the ready PRs ready to be merged label Nov 3, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) November 4, 2021 09:54
@SeanNaren SeanNaren merged commit a255dcb into master Nov 4, 2021
@SeanNaren SeanNaren deleted the fix/bfloat16_docs branch November 4, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve/Update bfloat16 docs

8 participants