Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant special case for disabling the progress bar on TPU #11061

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 14, 2021

What does this PR do?

Follow up to #9414

Now that all callback hooks run in the spawned processes, it is not longer needed to special case the TPU spawn plugin disabling the progress bar in a different way. The bar is already getting disabled in the Trainer._run_x methods. Further refactors may include moving the check to the progress bar (don't ask for it in this PR).

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @kaushikb11 @justusschock @awaelchli @akihironitta

@awaelchli awaelchli added this to the 1.6 milestone Dec 14, 2021
@awaelchli awaelchli added accelerator: tpu Tensor Processing Unit refactor labels Dec 14, 2021
@awaelchli awaelchli marked this pull request as ready for review December 14, 2021 17:54
@mergify mergify bot added the ready PRs ready to be merged label Dec 14, 2021
@awaelchli awaelchli requested a review from kaushikb11 December 14, 2021 19:35
@carmocca carmocca enabled auto-merge (squash) December 14, 2021 20:21
@carmocca carmocca merged commit c335a78 into master Dec 16, 2021
@carmocca carmocca deleted the refactor/spawn/disable-progbar branch December 16, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants