-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CVE-2020-1747 and CVE-2020-14343 #11099
Conversation
d613821
to
a59e96a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we check that it is fully back compatible with past checkpoints?
@Borda It isn't if the checkpoint yaml requires arbitrary code execution. |
What does this PR do?
Fixes #11045
Does your PR introduce any breaking changes? If yes, please list them.
If users were relying on the capabilities of
UnsafeLoader
when loading thehparams
, this will be a breaking change.Before submitting
PR review
cc @Borda