Add Progress Bar to docs #11359
Merged
Add Progress Bar to docs #11359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
requested review from
awaelchli,
Borda,
edenlightning and
tchaton
as code owners
|
hey @kaushikb11 ! doc test failing. can you fix them for review? |
ethanwharris
approved these changes
Jan 7, 2022
ananthsub
reviewed
Jan 7, 2022
akihironitta
reviewed
Jan 9, 2022
awaelchli
reviewed
Jan 16, 2022
There was a problem hiding this comment.
Seems like :noindex: is needed somewhere for the build to be successful. https://app.circleci.com/pipelines/github/PyTorchLightning/pytorch-lightning/51279/workflows/aa13874c-25d0-4170-8294-216da74189f5/jobs/146122?invite=true#step-103-616
Warning, treated as error:
/home/docs/project/pytorch_lightning/callbacks/progress/rich_progress.py:docstring of pytorch_lightning.callbacks.progress.rich_progress.RichProgressBar:1:duplicate object description of pytorch_lightning.callbacks.progress.rich_progress.RichProgressBar, other instance in common/generated/pytorch_lightning.callbacks.progress.RichProgressBar, use :noindex: for one of them
Makefile:19: recipe for target 'html' failed
Borda
approved these changes
Jan 18, 2022
|
Converting this PR to draft to avoid accidentally getting merged to master. |
kaushikb11
force-pushed
the
docs/progress_bar
branch
from
9629a04 to
951381b
Compare
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
Co-authored-by: thomas chaton <thomas@grid.ai>
kaushikb11
force-pushed
the
docs/progress_bar
branch
from
7fdbcb5 to
ff7d733
Compare
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #11359 +/- ##
========================================
- Coverage 92% 88% -4%
========================================
Files 207 207
Lines 17705 17705
========================================
- Hits 16235 15522 -713
- Misses 1470 2183 +713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #7666
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @rohitgr7 @SeanNaren @kaushikb11 @awaelchli