Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment variable order for global rank determination #11406

Merged
merged 9 commits into from
Feb 17, 2022

Conversation

konstantinjdobler
Copy link
Contributor

@konstantinjdobler konstantinjdobler commented Jan 10, 2022

This resolves the issue #11380 and the underlying root bug described here #11380 (comment).

Fixes #11380

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
@carmocca carmocca added bug Something isn't working environment: slurm labels Jan 12, 2022
@awaelchli awaelchli added this to the 1.5.x milestone Jan 16, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 16, 2022
@mergify mergify bot requested a review from a team January 16, 2022 02:44
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind add chlog entry?

@carmocca carmocca requested a review from ananthsub February 2, 2022 21:41
@mergify mergify bot added the has conflicts label Feb 5, 2022
@mergify mergify bot removed the has conflicts label Feb 10, 2022
@awaelchli awaelchli modified the milestones: 1.5.x, 1.6 Feb 17, 2022
@awaelchli awaelchli enabled auto-merge (squash) February 17, 2022 00:52
@awaelchli awaelchli merged commit d902b59 into Lightning-AI:master Feb 17, 2022
@awaelchli
Copy link
Contributor

Thanks for the patience @konstantinjdobler
This change will be included in the next release, 1.6

rohitgr7 pushed a commit that referenced this pull request Feb 17, 2022

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working environment: slurm ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WandbLogger in DDP setting creates multiple runs in W&B
7 participants