Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codebase to use trainer.loggers over trainer.logger when needed #11920

Merged
merged 25 commits into from
Feb 26, 2022
Merged

Refactor codebase to use trainer.loggers over trainer.logger when needed #11920

merged 25 commits into from
Feb 26, 2022

Conversation

akashkw
Copy link
Contributor

@akashkw akashkw commented Feb 14, 2022 •
edited
Loading

What does this PR do?

Refactors codebase to not use trainer.logger and LoggerCollection wherever multiple loggers may appear. Instead use trainer.loggers.

Part of #11232

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akashkw akashkw force-pushed the refactor/switch-to-loggers-property branch from 1a89b4b to 6cda5b5 Compare February 15, 2022 00:13
@akashkw akashkw force-pushed the refactor/switch-to-loggers-property branch from 5e223d7 to 44b2fb4 Compare February 15, 2022 19:44
@akashkw akashkw added logger Related to the Loggers refactor labels Feb 15, 2022
@akashkw akashkw marked this pull request as ready for review February 15, 2022 20:49
@akashkw akashkw force-pushed the refactor/switch-to-loggers-property branch from 2db1cab to 649260d Compare February 15, 2022 23:28
carmocca
carmocca reviewed Feb 16, 2022
View reviewed changes
pytorch_lightning/callbacks/gpu_stats_monitor.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/lr_monitor.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/lr_monitor.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/model_checkpoint.py Show resolved Hide resolved
pytorch_lightning/callbacks/progress/base.py Show resolved Hide resolved
pytorch_lightning/plugins/precision/precision_plugin.py Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Feb 23, 2022
@daniellepintz daniellepintz added this to the 1.6 milestone Feb 23, 2022
daniellepintz
daniellepintz approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@daniellepintz daniellepintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daniellepintz
Copy link
Contributor

Can we put back the revert early if no loggers change, since that doesnt seem like it caused the failures?

@akashkw akashkw force-pushed the refactor/switch-to-loggers-property branch from c0f411b to c277c90 Compare February 25, 2022 21:55
rohitgr7
rohitgr7 approved these changes Feb 25, 2022
View reviewed changes
tests/utilities/test_logger.py Outdated Show resolved Hide resolved
@akashkw akashkw force-pushed the refactor/switch-to-loggers-property branch from 245f68a to 961faef Compare February 25, 2022 22:40
@ananthsub ananthsub merged commit 7e2f9fb into Lightning-AI:master Feb 26, 2022
@akashkw akashkw deleted the refactor/switch-to-loggers-property branch February 26, 2022 00:11
@akashkw akashkw mentioned this pull request Feb 26, 2022
Closed
This was referenced Mar 2, 2022
Open
Merged
facebook-github-bot pushed a commit to facebookresearch/d2go that referenced this pull request Mar 4, 2022
@tangbinh @facebook-github-bot
Refactor codebase to use trainer.loggers over trainer.logger when…
c24d937 
… needed (#11920)

Summary:
### New commit log messages
- [7e2f9fbad Refactor codebase to use `trainer.loggers` over `trainer.logger` when needed (#11920)](Lightning-AI/pytorch-lightning#11920)

Reviewed By: edward-io

Differential Revision: D34583686

fbshipit-source-id: 98e557b761555c24ff296fff3ec6881d141fa777
@daniellepintz daniellepintz mentioned this pull request Mar 6, 2022
Merged
12 tasks
@akashkw akashkw mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellepintz daniellepintz daniellepintz approved these changes

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@ananthsub ananthsub ananthsub approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
logger Related to the Loggers ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@akashkw @daniellepintz @ananthsub @awaelchli @carmocca @rohitgr7