Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back deterministic support in accelerator_connector #11999

Merged
merged 6 commits into from
Feb 20, 2022
Merged

Add back deterministic support in accelerator_connector #11999

merged 6 commits into from
Feb 20, 2022

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Feb 19, 2022 •
edited by awaelchli
Loading

What does this PR do?

Address missing logic introduced in #11448

Part of #11449

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@four4fish four4fish added this to the 1.6 milestone Feb 19, 2022
@four4fish four4fish added the bug Something isn't working label Feb 19, 2022
ananthsub
ananthsub approved these changes Feb 19, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Feb 19, 2022
justusschock
justusschock approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some minor comments in the environment variables. Let's try to only add them when relevant

tests/accelerators/test_accelerator_connector.py Show resolved Hide resolved
pytorch_lightning/trainer/connectors/accelerator_connector.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/connectors/accelerator_connector.py Show resolved Hide resolved
awaelchli
awaelchli approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @four4fish

pytorch_lightning/trainer/connectors/accl_old.py Outdated Show resolved Hide resolved
@awaelchli awaelchli mentioned this pull request Feb 19, 2022
Merged
12 tasks
four4fish and others added 6 commits February 19, 2022 21:30
@four4fish
Add back deterministic support in accelerator_connector
76515ec
@four4fish
add change log
495f819
@four4fish @ananthsub
Update CHANGELOG.md
3d23fba 
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
@four4fish
update changelog
cadd74a
@four4fish @justusschock
Apply suggestions from code review
419d378 
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
@four4fish
address comments
7c0f0cf
@awaelchli awaelchli enabled auto-merge (squash) February 20, 2022 16:45
tchaton
tchaton approved these changes Feb 20, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli merged commit e15a664 into Lightning-AI:master Feb 20, 2022
justusschock added a commit that referenced this pull request Feb 21, 2022
@four4fish @ananthsub @justusschock
Add back deterministic support in accelerator_connector (#11999)
89d7d38 

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@justusschock justusschock justusschock approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@carmocca carmocca Awaiting requested review from carmocca

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged trainer: connector
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@four4fish @ananthsub @awaelchli @tchaton @justusschock @kaushikb11