Move ipu precision flag check to IPUPrecisionPlugin init #12148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
four4fish
requested review from
tchaton,
SeanNaren,
carmocca,
Borda,
awaelchli and
justusschock
as code owners
ananthsub
added
accelerator: ipu (removed)
ananthsub
approved these changes
Mar 1, 2022
kaushikb11
approved these changes
Mar 1, 2022
ananthsub
reviewed
Mar 1, 2022
ananthsub
reviewed
Mar 1, 2022
kaushikb11
approved these changes
Mar 3, 2022
ethanwharris
approved these changes
Mar 3, 2022
carmocca
approved these changes
Mar 4, 2022
awaelchli
approved these changes
Mar 4, 2022
Comment on lines
+41
to
+42
| f"`Trainer(accelerator='ipu', precision={precision!r})` is not supported." | ||
| f" `precision` must be one of: {supported_precision_values}." |
There was a problem hiding this comment.
So the reason we had the check in the accelerator connector is because the error message is not accurate when instantiating the plugin (or a subclass of it) outside the Trainer. So yeah, not ideal to move it here :)
There was a problem hiding this comment.
@awaelchli do you mean that user may init the precision plugin by themselves? Are you suggesting keep this in accl_connt?
There was a problem hiding this comment.
do you mean that user may init the precision plugin by themselves?
in general yes, that's what the plugins are meant to be used for. For the IPU precision specifically, nobody will. Still, the error message making a reference to the Trainer is misleading.
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
four4fish
requested review from
williamFalcon,
edenlightning and
rohitgr7
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #11449 follow up item 1
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃